-
Notifications
You must be signed in to change notification settings - Fork 378
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Extensions] Add a namespace for extension methods to prevent possible naming clashes #1776
Conversation
…onents.Extensions"
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm ok with the changes, but as it is a (minor) breaking change, I dont want to release this in a patch release. Think it is better to hold it for the next minor release as we give those more publicity and exposure.
Yes, we can wait for v4.7. But we could merge it, in |
✅ All tests passed successfully Details on your Workflow / Core Tests page. |
Summary - Unit Tests Code CoverageSummary
CoverageMicrosoft.FluentUI.AspNetCore.Components - 51.6%
|
[Extensions] Update of the namespace for all extension methods
#1762
Most projects add
@using Microsoft.FluentUI.AspNetCore.Components
to_Imports.razor
.To avoid conflicts with existing methods in other libraries, we've decided to place extension
methods in a Extensions sub-namespace.
This can be a minor breaking-change: requiring only an
using
.For existing projects:
@using Microsoft.FluentUI.AspNetCore.Components.Extensions
to_Imports.razor
file.using Microsoft.FluentUI.AspNetCore.Components.Extensions
to the top of some C# files.In the case of a conflict, you can remove these lines to distinguish the methods of FluentUI.AspNetCore.Components
from those of other libraries.